'use_preview' => true - doesn't seem to work

[robbieaverill]

Comments 3.2.x-dev

Not sure if this was supposed to do an AJAX request to get a rendered comment preview or something, but all it does now is render an empty field on the frontend:

Nothing in the JS console.

[NightJar]

    html_allowed: false # allow for sanitized HTML in comments
    html_allowed_elements:
      - a
      - img
      - i
      - b
    use_preview: false # preview formatted comment (when allowing HTML). Requires include_js=true

Indicates that HTML is disabled by default, and is required for the preview.
Arguably the use_preview setting should be ignored if html_allowed is false.

silverstripe-comments/src/Forms/CommentForm.php

Line 97 in e21a092

->setAttribute('style', 'display: none') // enable through JS

The above however indicates that the assumption of AJAX is correct, and https://github.com/silverstripe/silverstripe-comments/blob/3812057b0075cf37fccc5111fa35b5a754aa6031/javascript/CommentsInterface.js contains no reference to preview at all.

[NightJar]

This functionality was commented out when the nested comments concept was introduced.

silverstripe-comments/javascript/CommentsInterface.js

Line 13 in 468df23

// @todo Reinstate preview-comment functionality

This code was removed for the next major version as it was all commented out.

silverstripe-comments/javascript/CommentsInterface.js

Lines 99 to 134 in 468df23

	/**
	* Preview comment by fetching it from the server via ajax.
	*/
	/* @todo Migrate to work with nested comments
	$(':submit[name=action_doPreviewComment]', form).click(function(e) {
	e.preventDefault();
	if(!form.validate().valid()) {
	return false;
	}
	previewEl.show().addClass('loading').find('.middleColumn').html(' ');
	form.ajaxSubmit({
	success: function(response) {
	var responseEl = $(response);
	if(responseEl.is('form')) {
	// Validation failed, renders form instead of single comment
	form.find(".data-fields").replaceWith(responseEl.find(".data-fields"));
	} else {
	// Default behaviour
	previewEl.removeClass('loading').find('.middleColumn').html(responseEl);
	}
	},
	data: {'action_doPreviewComment': 1}
	});
	});
	*/
	/**
	* Hide outdated preview on form changes
	*/
	/*
	$(':input', form).on('change keydown', function() {
	previewEl.removeClass('loading').hide();
	});*/

[NightJar]

Question time:
reinstate, or complete the removal?