-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to phpoffice/phpword #58
Comments
I'm really not sure about that last ACs. I'm personally happy to just let go of |
All the checkboxes etc in CMS 4/5 version of document converter simply don't work as intended - checkboxes etc being everything above the upload field They're not included in the POST request that's sent to the server when you select a file in the ImportField (subclass on UploadField) I've tried in on CMS 3 and I get this post request when I select a file: CMS 3: Extra data gets attached via jquery via https://github.com/silverstripe/silverstripe-documentconverter/blob/1/javascript/DocumentImportField.js#L36
CMS 4/5: At some point it might have attached via jquery if there was ever a jquery file uploader in CMS 4 (I don't know the full history of it), though it no longer does https://github.com/silverstripe/silverstripe-documentconverter/blob/2/javascript/DocumentConversionField.js#L36 - simply the react uploadfield doesn't trigger jquery handlers. The Also the
|
We've decided not to do that. |
docvert is old and unmaintained.
phpoffice/phpword
provides better support and can be used without installing other libs on the server.Acceptance criteria
phpoffice/phpword
by default to convert document to WYSIWYG contentPRs
The text was updated successfully, but these errors were encountered: