Merge pull request #11166 from creative-commoners/pulls/5/check-exists

MNT Ensure composer/semver installed or skip test
silverstripe · Mar 4, 2024 · 054c238 · 054c238
2 parents 4f3282b + a18fb1b
commit 054c238
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/tests/php/Core/Manifest/VersionProviderTest.php b/tests/php/Core/Manifest/VersionProviderTest.php
@@ -65,7 +65,7 @@ public function testGetModulesNone()
     public function testGetModuleVersionFromComposer()
     {
         Config::modify()->set(VersionProvider::class, 'modules', [
-            'silverstripe/siteconfig' => 'SiteConfig',
+            'silverstripe/config' => 'Config',
             'silverstripe/framework' => 'Framework',
         ]);
 
@@ -77,17 +77,20 @@ public function testGetModuleVersionFromComposer()
     public function testGetVersion()
     {
         Config::modify()->set(VersionProvider::class, 'modules', [
-            'silverstripe/siteconfig' => 'SiteConfig',
+            'silverstripe/config' => 'Config',
             'silverstripe/framework' => 'Framework'
         ]);
         $result = $this->getProvider()->getVersion();
-        $this->assertStringNotContainsString('SiteConfig: ', $result);
+        $this->assertStringNotContainsString('Config: ', $result);
         $this->assertStringContainsString('Framework: ', $result);
         $this->assertStringNotContainsString(', ', $result);
     }
 
     public function testGetModuleVersion()
     {
+        if (!class_exists(VersionParser::class)) {
+            $this->markTestSkipped('This test requires composer/semver to be installed');
+        }
         $provider = $this->getProvider();
         Config::modify()->set(VersionProvider::class, 'modules', [
             'silverstripe/framework' => 'Framework',