FIX remove placeholder search text on readonly field

silverstripe · Oct 10, 2024 · 30049dd · 30049dd
1 parent 483e944
commit 30049dd
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/src/Forms/SearchableDropdownTrait.php b/src/Forms/SearchableDropdownTrait.php
@@ -139,7 +139,6 @@ public function getPlaceholder(): string
                 return $emptyString;
             }
         }
-        $name = $this->getName();
         if ($this->getUseDynamicPlaceholder()) {
             if ($this->getIsSearchable()) {
                 if (!$this->getIsLazyLoaded()) {
@@ -598,6 +597,9 @@ public function performReadonlyTransformation()
         $field->setSource($this->sourceList);
         $field->setReadonly(true);
 
+        // Remove the text "Type to search..." on a read-only field
+        $field->setUseDynamicPlaceholder(false);
+
         return $field;
     }
 }
diff --git a/tests/php/Forms/SearchableDropdownTraitTest.php b/tests/php/Forms/SearchableDropdownTraitTest.php
@@ -73,6 +73,8 @@ public function testPlaceholder(): void
         $this->assertSame('My empty string', $field->getPlaceholder());
         $field->setPlaceholder('My placeholder');
         $this->assertSame('My placeholder', $field->getPlaceholder());
+        $readonlyField = $field->performReadonlyTransformation();
+        $this->assertSame('', $readonlyField->getPlaceholder());
     }
 
     public function testSeachContext(): void