You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
#10335 introduces configuration to set a default samesite value for cookies, but because of BC concerns we couldn't add parameters to set a specific samesite value for any (separate) given cookie.
Acceptance criteria
$sameSite param = '' is added as added to the following:
CookieJar::outputCookie()
Cookie::set(), Cookie_Backend::set() and CookieJar::set()
Cookie::forceExpiry(), Cookie_Backend::forceExpiry() and CookieJar::forceExpiry()?
Anywhere else it's needed
When the default blank string param is used, fallback to the Cookie.default_samesite configuration variable
Session::start() should pass its samesite value into this parameter instead of CookieJar checking the Session.cookie_samesite config.
GuySartorelli
changed the title
v5: Add parameters to set samesite for any arbitrary cookie
Add parameters to set samesite for any arbitrary cookie
Feb 3, 2025
#10335 introduces configuration to set a default samesite value for cookies, but because of BC concerns we couldn't add parameters to set a specific samesite value for any (separate) given cookie.
Acceptance criteria
$sameSite param = ''
is added as added to the following:CookieJar::outputCookie()
Cookie::set()
,Cookie_Backend::set()
andCookieJar::set()
Cookie::forceExpiry()
,Cookie_Backend::forceExpiry()
andCookieJar::forceExpiry()
?Cookie.default_samesite
configuration variableSession::start()
should pass itssamesite
value into this parameter instead ofCookieJar
checking theSession.cookie_samesite
config.PRs
Kitchen sink CI run
Note this doesn't include any fixes from silverstripe/.github#376 so some builds may be red
Compare with https://github.com/silverstripe/recipe-kitchen-sink/actions/runs/13821934870
The text was updated successfully, but these errors were encountered: