Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DBClassNameTrait using wrong parent constructor arguments #11373

Closed
emteknetnz opened this issue Sep 12, 2024 · 1 comment
Closed

DBClassNameTrait using wrong parent constructor arguments #11373

emteknetnz opened this issue Sep 12, 2024 · 1 comment
Assignees
@GuySartorelli

Comments

@emteknetnz
Copy link
Member

emteknetnz commented Sep 12, 2024 •
edited
Loading

DBClassNameTrait can have a parent class that is either DBVarchar and DBEnum

They have different constructor params, so need to add conditional logic

PR
@emteknetnz emteknetnz self-assigned this Sep 12, 2024
This was referenced Sep 12, 2024
Merged
Merged
@emteknetnz emteknetnz removed their assignment Sep 12, 2024
@GuySartorelli GuySartorelli self-assigned this Sep 12, 2024
@GuySartorelli
Copy link
Member

PR merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GuySartorelli GuySartorelli

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@emteknetnz @GuySartorelli