Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue with embed/embed 4.4.13 #11473

Closed
emteknetnz opened this issue Nov 22, 2024 · 1 comment
Closed

Issue with embed/embed 4.4.13 #11473

emteknetnz opened this issue Nov 22, 2024 · 1 comment
Labels
affects/v5 type/other

Comments

@emteknetnz
Copy link
Member

emteknetnz commented Nov 22, 2024 •
edited
Loading

New issue that showed up in CI, did not happen with 4.4.12, started with 4.4.13 - diff

 1) SilverStripe\View\Tests\Embed\EmbedContainerTest::testGetDimensions
TypeError: preg_match(): Argument #2 ($subject) must be of type string, null given

/home/runner/work/recipe-kitchen-sink/recipe-kitchen-sink/vendor/embed/embed/src/Document.php:31

https://github.com/creative-commoners/recipe-kitchen-sink/actions/runs/11963492575/job/33354106153

Happens in CMS 6, haven't tested in CMS 5

PRs
@emteknetnz emteknetnz self-assigned this Nov 24, 2024
@emteknetnz emteknetnz mentioned this issue Nov 24, 2024
Merged
@emteknetnz emteknetnz removed their assignment Nov 24, 2024
@GuySartorelli
Copy link
Member

PR merged

@GuySartorelli GuySartorelli mentioned this issue Nov 24, 2024
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects/v5 type/other
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@emteknetnz @GuySartorelli