Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor LinkField around FormSchema #105

Closed
maxime-rainville opened this issue Oct 19, 2023 · 2 comments
Closed

Refactor LinkField around FormSchema #105

maxime-rainville opened this issue Oct 19, 2023 · 2 comments

Comments

@maxime-rainville
Copy link

maxime-rainville commented Oct 19, 2023

As a CMS Squad, we want the LinkField to use best practices to manage its communication with the backend so it's easy to maintain in the long run.

Acceptance criteria

  • Only the Link ID is communicated to the front end (rather than a big JSON blob)
  • Initial Link Title and Description is fetched via a scaffolded GraphQL schema.
  • The form schema in the Link Modal is retrieved via the ID of the link being edited.
  • When the Link modal is submitted, the link is created/updated on the spot.
  • LinkField is updated to remove the logic to handle scenarios where the type of a link is changed.

Exclude

  • Form schema validation

PRs

@maxime-rainville maxime-rainville transferred this issue from silverstripe/silverstripe-admin Oct 19, 2023
@maxime-rainville
Copy link
Author

We initially wanted to block this card on "Standardised how we create API/FormSchema endpoint in the CMS". We decided to reverse the block and use this card as a POC. We'll learn lessons from this card and reimplement it later on to use the new standard.

@maxime-rainville
Copy link
Author

Achievement unlocked!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants