Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Versioned UI state (of link owner record) after link creation and deletion #152

Closed
3 tasks
emteknetnz opened this issue Dec 19, 2023 · 1 comment
Closed
3 tasks
Assignees

Comments

@emteknetnz
Copy link
Member

emteknetnz commented Dec 19, 2023

After a link is created and the underlying parent object is directly saved in the database, as part of this card, the versioned UI state should be correct

Examples:

  • For a freshly published Page with a LinkField on it, when a new Link is added, the Page versioned UI state should be a clean Save button, and a dirty Published button.
  • For a freshly published Content Block Page with a LinkField on a Content Block, when a new Link is added, the Content Block should have a modified versioned state, and the page its only should have a clean Save button, and a dirty Published button.

Notes

  • Should be able to use the existing javascript change tracker to update this, rather than directly updating the save and publish buttons via jquery

Acceptance criteria

  • The versioned state UI for pages is correct when new Links are added or deleted
  • The versioned state UI for content blocks is correct when new Links are added or deleted
  • If there are any unsaved changes on the page/block at the time the link is added/deleted, the save button should remain in a dirty state.

PR

New issues created

@emteknetnz emteknetnz changed the title Versioned UI state after link creation Versioned UI state after link creation and deletion Dec 19, 2023
@emteknetnz emteknetnz transferred this issue from silverstripe/.github Jan 7, 2024
@GuySartorelli GuySartorelli changed the title Versioned UI state after link creation and deletion Versioned UI state (of link owner record) after link creation and deletion Jan 16, 2024
@emteknetnz emteknetnz self-assigned this Jan 28, 2024
@emteknetnz emteknetnz removed their assignment Jan 30, 2024
@sabina-talipova
Copy link
Contributor

PR's merged. Task was completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants