Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clicking Archive/Delete button should give "are you sure" prompt #175

Closed
emteknetnz opened this issue Jan 18, 2024 · 1 comment
Closed

Clicking Archive/Delete button should give "are you sure" prompt #175

emteknetnz opened this issue Jan 18, 2024 · 1 comment
Assignees
@GuySartorelli
Labels
type/enhancement

Comments

@emteknetnz
Copy link
Member

emteknetnz commented Jan 18, 2024 •
edited
Loading

When inline archive an element, you get this prompt:

image

LinkField should do the same when clicking Archive/Delete, rather than the instant delete that happens now. People could easily misclick it.

Acceptance criteria

  • The user needs to confirm they want to delete the link before it gets deleted.

PR
@emteknetnz emteknetnz self-assigned this Jan 24, 2024
@emteknetnz emteknetnz mentioned this issue Jan 24, 2024
Merged
@emteknetnz emteknetnz removed their assignment Jan 24, 2024
@GuySartorelli
Copy link
Member

PR merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GuySartorelli GuySartorelli

Labels
type/enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@emteknetnz @GuySartorelli