NEW LinkField Behat tests #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabina-talipova
force-pushed
the
pulls/4/linkfield-behat-tests
branch
11 times, most recently
from
b24c9b7 to
bb1c998
Compare
|
Failed tests require silverstripe/silverstripe-frameworktest#162 |
emteknetnz
requested changes
Feb 8, 2024
Comment on lines
100
to
108
| # Test that user can reorder links | ||
|
|
||
| ## These test steps give inconsistent results, not always passed | ||
| # And I drag the "#Form_ElementForm_1_PageElements_1_ManyLinks_Holder .link-picker__link--is-first" element to the "#Form_ElementForm_1_PageElements_1_ManyLinks_Holder .link-picker__link--is-last" element | ||
| # And I wait for 5 seconds | ||
| # Then I press the "Publish" button | ||
| # Then I click on the ".element-editor__element" element | ||
| # And I should see "All about us" in the "#Form_ElementForm_1_PageElements_1_ManyLinks_Holder .link-picker__link--is-last" element | ||
| # And I should see "Phone" in the "#Form_ElementForm_1_PageElements_1_ManyLinks_Holder .link-picker__link--is-first" element |
There was a problem hiding this comment.
Suggested change
| # Test that user can reorder links | |
| ## These test steps give inconsistent results, not always passed | |
| # And I drag the "#Form_ElementForm_1_PageElements_1_ManyLinks_Holder .link-picker__link--is-first" element to the "#Form_ElementForm_1_PageElements_1_ManyLinks_Holder .link-picker__link--is-last" element | |
| # And I wait for 5 seconds | |
| # Then I press the "Publish" button | |
| # Then I click on the ".element-editor__element" element | |
| # And I should see "All about us" in the "#Form_ElementForm_1_PageElements_1_ManyLinks_Holder .link-picker__link--is-last" element | |
| # And I should see "Phone" in the "#Form_ElementForm_1_PageElements_1_ManyLinks_Holder .link-picker__link--is-first" element |
| I want to add links to pages, files, external URLs, email addresses and phone numbers | ||
|
|
||
| Background: | ||
| Given I add an extension "SilverStripe\FrameworkTest\LinkField\Extensions\LinkPageExtension" to the "Page" class |
There was a problem hiding this comment.
Update this to the new namespace of the extension copied in from the frameworktest PR
Also add in the new ElementContent extension I've mentioned on the frameworktest PR
Do this for the other behat file as well
| And I wait for 5 seconds | ||
| Then I should see "Link to external URL" in the ".modal-header" element | ||
| Then I fill in "Form_LinkForm_0_Title" with "External URL" | ||
| Then I fill in "Form_LinkForm_0_ExternalUrl" with "https://www.silverstripe.org" |
There was a problem hiding this comment.
Also add in a quick test here with an invalid URL to test that validation is working, then update it to a valid url
Comment on lines
33
to
34
|
|
||
|
|
sabina-talipova
force-pushed
the
pulls/4/linkfield-behat-tests
branch
3 times, most recently
from
3b358d5 to
294da79
Compare
sabina-talipova
commented
Feb 9, 2024
| Then I should see "Page on this site" in the ".modal-header" element | ||
| And I wait for 2 seconds | ||
| And I press the "Create link" button | ||
| Then I should see "Page is required" in the ".modal-content" element |
There was a problem hiding this comment.
Add test for validation
sabina-talipova
commented
Feb 9, 2024
| And I wait for 5 seconds | ||
| Then I should see "Link to external URL" in the ".modal-header" element | ||
| Then I fill in "Form_LinkForm_0_LinkText" with "External URL" | ||
| And I fill in "Form_LinkForm_0_ExternalUrl" with "w1234@$%" |
There was a problem hiding this comment.
Add test for invalid URL
sabina-talipova
commented
Feb 9, 2024
| Scenario: I can create link blocks page | ||
| Given I press the "Add block" button | ||
| # There are few buttons on the page with 'Content' text | ||
| Then I click on the ".font-icon-block-content" element |
There was a problem hiding this comment.
I have to change this to class name since there are more than one "Content" button on the page
sabina-talipova
commented
Feb 9, 2024
|
|
||
| Background: | ||
| Given I add an extension "SilverStripe\FrameworkTest\LinkField\Extensions\LinkPageExtension" to the "Page" class | ||
| And I go to "/dev/build?flush" |
There was a problem hiding this comment.
We should rebuild DB after new Extension was applied.
emteknetnz
requested changes
Feb 12, 2024
sabina-talipova
force-pushed
the
pulls/4/linkfield-behat-tests
branch
from
294da79 to
6ff2d80
Compare
emteknetnz
approved these changes
Feb 12, 2024
emteknetnz
requested changes
Feb 13, 2024
sabina-talipova
force-pushed
the
pulls/4/linkfield-behat-tests
branch
from
6ff2d80 to
da7c7c9
Compare
|
Updated. Sorry, I removed and forgot to return back. |
sabina-talipova
force-pushed
the
pulls/4/linkfield-behat-tests
branch
from
da7c7c9 to
1c54da7
Compare
sabina-talipova
force-pushed
the
pulls/4/linkfield-behat-tests
branch
from
1c54da7 to
24bf1ee
Compare
emteknetnz
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These changes add integration testing and test the operation of the linkfield as part of the SMS page and as part of the Elemental Block. The tests cover the following main aspects of the module's operation:
Parent issue
New issue
A problem was identified when using Mock classes that implement the TestOnly interface in Behat tests. Most likely, these classes are ignored when creating database tables, making it impossible to test complex relationships between classes.
Note
silverstripe / frameworktestand passed. See here