Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RegistryImportedFeed::setAssetHandler() Filesystem::addPlugin() no longer works #75

Open
emteknetnz opened this issue Dec 8, 2022 · 0 comments

Comments

@emteknetnz
Copy link
Member

emteknetnz commented Dec 8, 2022

https://github.com/silverstripe/silverstripe-registry/actions/runs/3645212467/jobs/6155159276

1) SilverStripe\Registry\Tests\RegistryImportFeedControllerTest::testNonExistentClassInLatestFeedReturnsNotFound
Error: Call to undefined method SilverStripe\Assets\Flysystem\Filesystem::addPlugin()

/home/runner/work/silverstripe-registry/silverstripe-registry/src/RegistryImportFeed.php:83
/home/runner/work/silverstripe-registry/silverstripe-registry/vendor/silverstripe/framework/src/Core/Injector/Injector.php:848
/home/runner/work/silverstripe-registry/silverstripe-registry/vendor/silverstripe/framework/src/Core/Injector/Injector.php:692
/home/runner/work/silverstripe-registry/silverstripe-registry/vendor/silverstripe/framework/src/Core/Injector/Injector.php:661
/home/runner/work/silverstripe-registry/silverstripe-registry/vendor/silverstripe/framework/src/Core/Injector/Injector.php:1029
/home/runner/work/silverstripe-registry/silverstripe-registry/vendor/silverstripe/framework/src/Core/Injector/Injector.php:982
/home/runner/work/silverstripe-registry/silverstripe-registry/vendor/silverstripe/framework/src/Core/Injector/Injector.php:1152
/home/runner/work/silverstripe-registry/silverstripe-registry/vendor/silverstripe/framework/src/Core/Injector/Injectable.php:30
/home/runner/work/silverstripe-registry/silverstripe-registry/tests/RegistryImportFeedTest.php:21

$handler->getFilesystem()->addPlugin(new ListFiles);

https://github.com/silverstripe/silverstripe-registry/blob/3/src/RegistryImportFeed.php#L83

This probably broke as part of the CMS 5 flysystem upgrade

I'm not sure what "ListFiles" does, if we just delete this line we may lose functionality here, though I'm not sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants