API Update import() signature #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emteknetnz
force-pushed
the
pulls/3/broken-builds
branch
2 times, most recently
from
4bae476 to
81ed54e
Compare
emteknetnz
changed the title
emteknetnz
changed the title
emteknetnz
force-pushed
the
pulls/3/broken-builds
branch
from
81ed54e to
1ff8d18
Compare
GuySartorelli
approved these changes
Dec 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
- silverstripe/cms[5.0.0-alpha1, ..., 5.x-dev] require silverstripe/versioned ^2 -> found silverstripe/versioned[2.0.0-alpha1, 2.x-dev] but it conflicts with your root composer.json require (^1.12).https://github.com/silverstripe/silverstripe-registry/actions/runs/3645000481/jobs/6154760365#step:9:277
Also updates RegistryAdmin::import() to be compatible with the updated signature on ModelAdmin::import()
Note: not fixing the
->addPlugin()CI failure - have raised a new issue for since it's not obvious what the fix here is since we may have lost functionality as part of the flysystem upgradeParent issue