Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language in warning on shared page is inconsistent with behaviour #114

Open
Cheddam opened this issue Jun 9, 2020 · 4 comments
Open

Language in warning on shared page is inconsistent with behaviour #114

Cheddam opened this issue Jun 9, 2020 · 4 comments

Comments

@Cheddam
Copy link
Member

Cheddam commented Jun 9, 2020

Tested version: 2.x-dev

Outline

The warning banner on a shared draft page states:

You are viewing the draft state of this page, any page you navigate to will be the published state.

However, links in standard Menu()s contain ?Stage=Stage, and will prompt the user to log in, so this statement is incorrect. Either the warning or the behaviour needs to be adjusted - I'm honestly not sure which approach makes more sense at this stage.

@Cheddam
Copy link
Member Author

Cheddam commented Jun 9, 2020

cc/ @silverstripeux

@sachajudd
Copy link
Contributor

sachajudd commented Jun 9, 2020

Could be related to when we update the front-end of the warning: #83

@clarkepaul
Copy link

We have to assume that people wont have access to log in as thats the problem space we are trying to solve.

Message could be something like:
You are viewing the draft state of this page, any other page you navigate to will be the published state unless you log into the CMS.

But in addition to that I think we should remove all the staging links (except the shared page) unless the user is logged in.

@clarkepaul
Copy link

Feels like we should be doing something a little more future proof as well but not sure exactly how e.g. ?Stage=Shared-xyz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants