Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching subsites when a subsite-specific file/folder is open breaks the detail view #404

Open
robbieaverill opened this issue Nov 27, 2018 · 3 comments · Fixed by #490

Comments

@robbieaverill
Copy link
Contributor

Version: CWP 2.2.x-dev (subsites 2.2)

  • Set up two subsites
  • Go into the assets area
  • Switch to a non-default subsite
  • Create a new file or folder
  • Set it to belong to the secondary subsite and save
  • With the detail screen for the file/folder still open, switch to another subsite

In some cases it would show me the detail view of the folder which should not be visible in that subsite, and in other cases it throws an error:

image

I'm not sure what the expected behaviour should be really. Perhaps there needs to be a change to asset-admin to handle this scenario (the folder doesn't exist in the current context, and/or the response to get its details fails).

@robbieaverill
Copy link
Contributor Author

robbieaverill commented May 8, 2019

and in other cases it throws an error:

This error is caused by one of the XHR requests returning HTML instead of JSON (I think). It's reproducible when you switch from a non-main subsite back to a main subsite while having a folder's detail view open at the same time.

@GuySartorelli
Copy link
Member

Fixed in #490. It will be tagged automatically when CI has finished running on the branch.

@GuySartorelli
Copy link
Member

The fix needed to be reverted - see #538

@GuySartorelli GuySartorelli reopened this Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants