Throw if versioned used on nested query

silverstripe · Sep 17, 2020 · 7e3ebfb · 7e3ebfb
1 parent e6fe184
commit 7e3ebfb
Showing 1 changed file with 8 additions and 0 deletions.
diff --git a/src/GraphQL/Resolvers/VersionFilters.php b/src/GraphQL/Resolvers/VersionFilters.php
@@ -3,6 +3,8 @@
 namespace SilverStripe\GraphQL\Resolvers;
 
 use SilverStripe\ORM\DataList;
+use SilverStripe\ORM\RelationList;
+use SilverStripe\ORM\UnsavedRelationList;
 use SilverStripe\Versioned\Versioned;
 use InvalidArgumentException;
 use DateTime;
@@ -61,6 +63,12 @@ public function applyToReadingState(array $versioningArgs)
      */
     public function applyToList(DataList $list, array $versioningArgs): DataList
     {
+        if ($list instanceof RelationList) {
+            throw new InvalidArgumentException(sprintf(
+                'Version filtering cannot be applied to instances of %s. Are you using the plugin on a nested query?',
+                get_class($list)
+            ));
+        }
         if (!isset($versioningArgs['mode'])) {
             $list;
         }