-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sspak-sniffter doesn't work with SS4 app object #59
Comments
Our quick fix is:
|
…ourtest @mikenz) - Replaced `use` keyword with full-namespace construction - Forced various $_SERVER env vars required by HTTPResponse.php - Uses .env file for DB credentials
The branch Thanks to @mikenz that formed the basis of this. |
see #64 |
This code seems to be very SS3 centric because there is no mention of
https://github.com/silverstripe/sspak/blob/master/src/DataExtractor/DatabaseConnector.php#L28-L44 |
https://github.com/silverstripe/sspak/blob/master/src/sspak-sniffer.php relies on Core.php and global $databaseConfig. For SilverStripe 4 this will need to change.
Ideally, the pre-app-object support for SS4 will still work.
The text was updated successfully, but these errors were encountered: