Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to not backup assets #85

Open
OldStarchy opened this issue May 12, 2022 · 2 comments
Open

Add option to not backup assets #85

OldStarchy opened this issue May 12, 2022 · 2 comments

Comments

@OldStarchy
Copy link

I have a number of docker containers running with a volume bound to the public/assets directory, when using sspak load it tries to move the assets to assets-old but since the directory is a volume it fails.
I've had success by commenting out

$this->execSudo("mv {$assetsPath} {$assetsOldPath}");

but it's a manual step I have to do every time as sspak is baked into the image and the containers are frequently rebuilt.

@dhensby
Copy link
Contributor

dhensby commented May 12, 2022

Seems like it should be fairly straightforward to do. Happy to open a PR?

@OldStarchy
Copy link
Author

OldStarchy commented May 26, 2022

Since raising this issue I 1. forgot I raised this issue and 2. changed our setup to not bind the assets to a docker volume. The point of the volume was to persist data between deployments but now our ci task will just create an sspak before taking down the old container and then use that to initialize the new container. As far as I'm concerned I no longer need this.

Additionally, I'm not sure that just optionally disabling this line is sufficient as just extracting the assets from the sspak would not remove any assets that are already there. (though in my case this was only used for fresh installs so it wouldn't matter anyway)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants