-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Functions should be static instead of instance-based. #22
Comments
This could be discussed indeed but you could also imagine to compare several series as follow : if(serie1.min() < serie2.min()) {
// whatever
} |
Yes, I think it is pretty simple to make it work both ways by having the instance methods call the static methods. Just a suggestion. 👍 |
Would you propose a pull to make it work both ways? |
Yes I'll work on it at some point this week. On Sat, Mar 21, 2015 at 12:13 PM Simon Georget [email protected]
|
@JoshMcCullough Apologies to ping an old issue. I've made GeoBuckets which is a modern take on geostats. All functions are static. Additionally the library is tree-shakable and asynchronous. Please let me know if that fulfills your usage scenario. If not, I'd be happy to accept PRs or make adjustments as needed |
@simogeo Awesome stuff! I appreciate the mention. Thank you for your continued work with geostats |
For most functions, it seems I should be able to simply call (for example),
geostats.min(values)
without creating ageostats
instance.I haven't used the library enough yet to understand when/why I'd want my own instance of
geostats
instead of just calling its functions statically.The text was updated successfully, but these errors were encountered: