add gallery of pal extensions #53
Conversation
vignettes/gallery.Rmd
Outdated
|
|
||
| gallery$description <- sapply(gallery$description, commonmark::markdown_html) | ||
|
|
||
| DT::datatable(gallery, escape = FALSE) |
There was a problem hiding this comment.
I think it'd be awesome to use gt + shinylive here to use gt::render_gt() but I couldn't quite figure out how to get pkgdown to play nicely with that output.
There was a problem hiding this comment.
Uh, apologies, I'm the wrong person for technical input on this one 🏄♀️
vignettes/gallery.Rmd
Outdated
| # multiple pals, include a row for each pal. | ||
| gallery <- | ||
| tibble::tribble( | ||
| ~description, ~role, ~interface, ~type, |
There was a problem hiding this comment.
Is this all relevant information to include? Am I missing anything key?
Ideas I had tossed around were 1) automatic generation of the prompt_new() code, 2) author, or 3) tags.
There was a problem hiding this comment.
I don't find the type column all that informative. What I do think would be very good to have is a column with "Use it via" information, so a minimal piece of code that you can c+p into your console and get going. For markdown files like mine, it would be prompt_new() but with the right URL (which needs to be the raw md content, not the github rendered page). For an extension package, it would be install.packages() or pak::pak(), with right name or user/repo info. Given that the URL for my markdown thing is rather long: a copy to clipboard button would be sooo nice, especially if that allowed you to hide the long URL somehow.
I don't think you need tags yet, I would revisit that once you feel you need it.
Re author: you/me as a user can live without it but since you would like to give visibility and encourage participation, I would add it.
There was a problem hiding this comment.
Thanks so much, @hfrick. :) Made all of your suggestions besides copy to clipboard—still trying to figure that one out but I think it's such a good idea.
There was a problem hiding this comment.
I think this is a good balance for where the project is at the moment and the nearer future. Once things get busier and the list gets longer, you can always adjust but right now, I'd view that as a serious risk of over-engineering. So yay for being pragmatic!
vignettes/gallery.Rmd
Outdated
| # multiple pals, include a row for each pal. | ||
| gallery <- | ||
| tibble::tribble( | ||
| ~description, ~role, ~interface, ~type, |
There was a problem hiding this comment.
I don't find the type column all that informative. What I do think would be very good to have is a column with "Use it via" information, so a minimal piece of code that you can c+p into your console and get going. For markdown files like mine, it would be prompt_new() but with the right URL (which needs to be the raw md content, not the github rendered page). For an extension package, it would be install.packages() or pak::pak(), with right name or user/repo info. Given that the URL for my markdown thing is rather long: a copy to clipboard button would be sooo nice, especially if that allowed you to hide the long URL somehow.
I don't think you need tags yet, I would revisit that once you feel you need it.
Re author: you/me as a user can live without it but since you would like to give visibility and encourage participation, I would add it.
vignettes/gallery.Rmd
Outdated
|
|
||
| gallery$description <- sapply(gallery$description, commonmark::markdown_html) | ||
|
|
||
| DT::datatable(gallery, escape = FALSE) |
There was a problem hiding this comment.
Uh, apologies, I'm the wrong person for technical input on this one 🏄♀️
* remove "type" column * add "Use it via..." and "author" columns
| @@ -27,8 +27,7 @@ Imports: | |||
| rstudioapi, | |||
| shiny | |||
| Suggests: | |||
| commonmark, | |||
| DT, | |||
| gt, | |||
There was a problem hiding this comment.
Did I introduce a buglet here that I'm not noticing? Or you're just observing the change?😄
There was a problem hiding this comment.
Still trying to make the "Copy to clipboard" change happen, and it seems like gt may be a better candidate as the tool to do so.
There was a problem hiding this comment.
Ah, sorry, that was not a critical side eye, that was just me trying to say "you made it happen!" 😆
gave up on copying to clipboard for now :/
Closes #45. Opted to go for a lighter-weight approach than the ones I had tossed around in the issue.