Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SupRsync Stats Bug #521

Merged
merged 1 commit into from
Sep 5, 2023
Merged

SupRsync Stats Bug #521

merged 1 commit into from
Sep 5, 2023

Conversation

kmharrington
Copy link
Member

@kmharrington kmharrington commented Sep 5, 2023

Description

Found file trying to figure out what's going on the the LAT finalization at the site

Motivation and Context

Looks like we were adding up the non-copied files in the way the logic actually works and then weren't actually reporting it. Using this num_files_to_copy variable will make the logic on what's going on with the finalization time match the number of files we need to copy number. Note, this won't actually fix the current issue with the LAT times.

How Has This Been Tested?

I haven't actually tested it because I'm not sure how

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Copy link
Collaborator

@jlashner jlashner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks katie, this definitely looks right. This seems simple enough that it's probably fine to merge without testing...

@BrianJKoopman BrianJKoopman merged commit 79b92b5 into main Sep 5, 2023
2 checks passed
@BrianJKoopman BrianJKoopman deleted the archive_stats_bug branch September 5, 2023 17:27
hnakata-JP pushed a commit that referenced this pull request Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants