Merge pull request #112 from simonsobs/koopman/issue-64

Provide user feedback when wrapping up a scan

src/sorunlib/seq.py

@@ -49,6 +49,7 @@ def scan(description, stop_time, width, az_drift=0, tag=None, subtype=None):
         run.commands.wait_until(stop_time)
     finally:
         # Stop motion
+        print("Stopping scan.")
         acu.generate_scan.stop()
         resp = acu.generate_scan.wait(timeout=OP_TIMEOUT)
         check_response(acu, resp)

src/sorunlib/smurf.py

@@ -325,6 +325,7 @@ def stream(state, tag=None, subtype=None):
 
     else:
         for smurf in run.CLIENTS['smurf']:
+            print(f'Turning off stream from {smurf.instance_id}.')
             smurf.stream.stop()
             resp = smurf.stream.wait()
             check_response(smurf, resp)

tests/test_smurf.py

@@ -128,7 +128,11 @@ def test_take_noise(concurrent):
         client.take_noise.start.assert_called_with(tag=None)
 
 
-def test_stream():
-    smurf.stream(state='on')
+@pytest.mark.parametrize("state", [("on"), ("off")])
+def test_stream(state):
+    smurf.stream(state=state)
     for client in smurf.run.CLIENTS['smurf']:
-        client.stream.start.assert_called_once()
+        if state == "on":
+            client.stream.start.assert_called_once()
+        else:
+            client.stream.stop.assert_called_once()