Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colored icon mode #277

Open
1 of 4 tasks
kidonng opened this issue Mar 6, 2023 · 4 comments
Open
1 of 4 tasks

Colored icon mode #277

kidonng opened this issue Mar 6, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@kidonng
Copy link

kidonng commented Mar 6, 2023

Kind of issue

  • Feature
  • Bug
  • Design
  • Other, namely:

Description

There's a reference color, and you can download colored icon, but there does not seem to be a way to see colored icon in-place.

@mondeja mondeja added the enhancement New feature or request label Apr 4, 2023
@mondeja
Copy link
Member

mondeja commented Apr 4, 2023

What would be the desired behaviour when the icon color is the same than the dark/light mode backgrounds?

@mondeja mondeja added the in discussion There is an ongoing discussion that should be finished before we can continue label Apr 4, 2023
@kidonng
Copy link
Author

kidonng commented Apr 4, 2023

I would assume it's rare since it's something you need to consider when choosing the color in the first place. I think it's fine to leave them as is, you just need to toggle the color off in order to see them properly.

@mondeja
Copy link
Member

mondeja commented Apr 4, 2023

I would assume it's rare since it's something you need to consider when choosing the color in the first place.

Note that this is not true because we choose the color of the icons based on the most representative color of the brand (see CONTRIBUTING in main project repository). Rather than that, any suggestion or implementation is welcome.

@mondeja mondeja removed the in discussion There is an ongoing discussion that should be finished before we can continue label Apr 4, 2023
@kidonng
Copy link
Author

kidonng commented Apr 4, 2023

One solution on top of my mind is to add a simple distinguishing outline, though it is not perfect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants