Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SCIM] Notification payload size too big #797

Open
gabrielemilan opened this issue Oct 24, 2024 · 7 comments
Open

[SCIM] Notification payload size too big #797

gabrielemilan opened this issue Oct 24, 2024 · 7 comments
Assignees
Labels
question Further information is requested

Comments

@gabrielemilan
Copy link
Contributor

Hello guys,

we have an issue with group notification.

We use Azure Service Bus, and it has (in standard tier) only 256kb payload limitation.

In our system we have a group with multiple users and when we add new user the notification of group payload exceeds 256kb.

Do you have a "workaround" for this issue? Or do we need to use Premium Azure Service Bus? That supports 100mb payload size?

Thanks

@simpleidserver simpleidserver self-assigned this Oct 26, 2024
@simpleidserver simpleidserver added the question Further information is requested label Oct 26, 2024
@simpleidserver simpleidserver moved this to In Progress in Release 5.0.3 Oct 26, 2024
@simpleidserver
Copy link
Owner

Hello,

There are two possible solutions to address your issue.

The first solution involves storing the content of the message in Blob storage and adding a reference to it within the message.
If you agree with this approach, we can make some modifications to the SCIM project to store the message content in Blob storage.
This will result in a smaller message that contains only a reference to the Blob.

The second solution is to split the message into chunks.
Unfortunately, the MassTransit NuGet package doesn’t support this feature, nor is it mentioned on their website.
If you feel more comfortable with this option, you could ask in their GitHub project whether message chunking is possible or if it might be supported in the future.

KR,
SID

@simpleidserver simpleidserver closed this as completed by moving to Done in Release 5.0.3 Oct 26, 2024
@gabrielemilan
Copy link
Contributor Author

Ok, after few investigation on our side, I think that the best approach is to implement first solution, I mean store message to blob storage, if possible with a setting to enable or disable it.

Can you please make this change?

Thanks a lot.

@simpleidserver simpleidserver moved this from Done to In Progress in Release 5.0.3 Nov 5, 2024
@simpleidserver
Copy link
Owner

We will add this feature in the next release.

KR,

SID

@simpleidserver
Copy link
Owner

I made some modifications to the Release503 branch to support your scenario.
Two new parameters have been added to the appsettings.json file.
It should look something like this to store messages in Azure Blob Storage:

"MassTransitStorageConfiguration": {
  "IsEnabled": true,
  "Type": "AZURESTORAGE",
  "ConnectionString": "https://{accountName}.blob.core.windows.net"
}

Changes : 54084df

@simpleidserver simpleidserver closed this as completed by moving to Done in Release 5.0.3 Nov 8, 2024
@simpleidserver simpleidserver reopened this Nov 8, 2024
@gabrielemilan
Copy link
Contributor Author

Nice, I will try it soon

@polybogdan
Copy link

Hello ,

We tested the changes and all seems fine. Do you already have the plan for the release of the new version ?

Regards

@simpleidserver
Copy link
Owner

A pre-release package, version 5.0.3-rc1, has been published and is available for use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
Status: Done
Development

No branches or pull requests

3 participants