Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Controller-classes to replace old www-dir #26

Open
tvdijen opened this issue Sep 24, 2019 · 4 comments · May be fixed by #37
Open

Introduce Controller-classes to replace old www-dir #26

tvdijen opened this issue Sep 24, 2019 · 4 comments · May be fixed by #37

Comments

@tvdijen
Copy link
Member

tvdijen commented Sep 24, 2019

SimpleSAMLphp is moving to Controller-classes to replace the files in the www-dir. We should start by migrating and remove the www-dir eventually when SSP 2.0 is released

@pradtke
Copy link
Collaborator

pradtke commented Jan 15, 2020

Hi @tvdijen do you know if there is a transition guide anywhere for moving to controller classes, or existing code that I could look at? I'm not sure how to begin the transition.

@tvdijen
Copy link
Member Author

tvdijen commented Dec 2, 2021

HI @pradtke ! Sorry I never got back to you.. There's no guide, but by now pretty much any module has been migrated to controllers, so you have a lot of examples.. I think by now you're the only one relying on this module, so I'm not sure how much time I should spend on it.. I can help you though if you need help?

@pradtke
Copy link
Collaborator

pradtke commented Dec 13, 2021

Thanks @tvdijen . I agree there are lots of examples now to base my changes on. I can do the conversion, along with other SSP v2 prep. Hopefully in January.

@tvdijen
Copy link
Member Author

tvdijen commented Dec 13, 2021

If you do this, we will most likely solve the test-failures in #25, since we don't need the builtin webserver anymore once we have controllers... I'll see if I can do some work on this, but since I'm not familiar with CAS, I have to rely on you for testing.

@tvdijen tvdijen linked a pull request Jul 11, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants