Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat]New connection methods #6

Merged
merged 1 commit into from
Nov 28, 2024
Merged

[Feat]New connection methods #6

merged 1 commit into from
Nov 28, 2024

Conversation

Drejzer
Copy link
Member

@Drejzer Drejzer commented Nov 27, 2024 •
edited
Loading

ADDITIONS

  • NativeConnectionWrapper::connect()
  • NativeConnectionWrapper::conectPublic()
  • Connection.connect(userPrivKey:solutionId:bridgeUrl:)
  • Connection.connectPublic(solutionId:bridgeUrl:)

MODIFICATIONS

  • Deprecated platformConnect() and platformConnectPublic() in NativeConnectionWrapper
  • Deprecated connect(userPrivKey:solutionId:platformUrl:) and connectPublic(solutionId:platformUrl:) in Connection

Closes #5

@Drejzer Drejzer self-assigned this Nov 27, 2024
bzyglarski
bzyglarski approved these changes Nov 27, 2024
View reviewed changes
Copy link
Member

@bzyglarski bzyglarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@Drejzer Drejzer merged commit 90921fe into dev Nov 28, 2024
@Drejzer Drejzer deleted the feat/new-connection-methods branch November 28, 2024 08:24
@Drejzer Drejzer linked an issue Nov 28, 2024 that may be closed by this pull request
[Feat] New connection methods #5
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzyglarski bzyglarski bzyglarski approved these changes

@filipg43 filipg43 filipg43 approved these changes

Assignees

@Drejzer Drejzer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feat] New connection methods
3 participants
@Drejzer @filipg43 @bzyglarski