Build issue fix: replacing the cyhunspell package with a different package that maintains the same API #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot, @Hrazhan gyan. All clear. Merged! |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cyhunspell is no longer maintained and cannot be easily built for recent versions of Python, which causes the installation of klpt to break. This pull request provides a quick fix by replacing cyhunspell with a more up-to-date, actively maintained version of the wrapper.
cHunSpell is another wrapper around Hunspell that has fewer dependencies and no build issues for Python 3.11 and 3.12. It maintains the same API as cython_hunspell, so there is no need for any change from the KLPT side. I have tested all the functions from the Stem module, and they all work fine with it.
I have also updated GitHub Actions workflow to build and test the project using Python 3.8 and later versions. Python 3.7 has reached its end-of-life and is no longer supported.