Don't allow “shift” key without other modifiers or function key

Fixes #54
sindresorhus · Sep 11, 2021 · 7030a2e · 7030a2e
1 parent 52b5666
commit 7030a2e
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/Sources/KeyboardShortcuts/RecorderCocoa.swift b/Sources/KeyboardShortcuts/RecorderCocoa.swift
@@ -207,8 +207,9 @@ extension KeyboardShortcuts {
 					return nil
 				}
 
+				// The “shift” key is not allowed without other modifiers or a function key, since it doesn't actually work.
 				guard
-					!event.modifiers.isEmpty
+					!event.modifiers.subtracting(.shift).isEmpty
 						|| event.specialKey?.isFunctionKey == true,
 					let shortcut = Shortcut(event: event)
 				else {