Make file heading link to the first error (#38)

Fixes #37
sindresorhus · Jan 11, 2019 · a0cc031 · a0cc031
1 parent 492a0e3
commit a0cc031
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 2 deletions.
diff --git a/index.js b/index.js
@@ -47,11 +47,13 @@ module.exports = results => {
 				lines.push({type: 'separator'});
 			}
 
+			const firstErrorOrWarning = messages.find(({severity}) => severity === 2) || messages[0];
+
 			lines.push({
 				type: 'header',
 				filePath,
 				relativeFilePath: path.relative('.', filePath),
-				firstLineCol: messages[0].line + ':' + messages[0].column
+				firstLineCol: firstErrorOrWarning.line + ':' + firstErrorOrWarning.column
 			});
 
 			messages

diff --git a/test/test.js b/test/test.js
@@ -42,10 +42,24 @@ test('output', t => {
 	disableHyperlinks();
 	const output = m(defaultFixture);
 	console.log(output);
-	t.regex(stripAnsi(output), /index\.js:8:2\n/);
+	t.regex(stripAnsi(output), /index\.js:18:2\n/);
 	t.regex(stripAnsi(output), /✖[ ]{3}1:1[ ]{2}AVA should be imported as test.[ ]{6}ava\/use-test/);
 });
 
+test('file heading links to the first error line', t => {
+	disableHyperlinks();
+	const output = m(defaultFixture);
+	console.log(output);
+	t.regex(stripAnsi(output), /index\.js:18:2\n/);
+});
+
+test('file heading links to the first warning line if no errors in the file', t => {
+	disableHyperlinks();
+	const output = m(defaultFixture);
+	console.log(output);
+	t.regex(stripAnsi(output), /test\.js:1:1\n/);
+});
+
 test('no line numbers', t => {
 	disableHyperlinks();
 	const output = m(noLineNumbers);