Rule proposal: Prefer Array.from() callback for list comprehensions

[geoffswift]

Description

I've seen a bunch of examples where Array(n).keys() is used as part of a list comprehension. Since keys() here returns an iterator the typical form is like Array.from(Array(n).keys()) or [...Array(n).keys()]

This has the overhead of extra intermediate array(s) and using the callback for Array.from() although more verbose is the best performer.

See examples for details.

Examples

// ❌
Array.from(Array(n).keys())

// ❌
[...Array(n).keys()]

// ✅
Array.from({ length: n }, (_, i) => i)

// ❌
Array.from(Array(n).keys()).map((i) => ({ id: i, }));

// ❌
[...Array(n).keys()].map((i) => ({ id: i, }));

// ✅
Array.from({ length: n }, (_, i) => ({ id: i, }))

Proposed rule name

prefer-callback-for-list-comprehension

Additional Info

No response