Always return response with status 200 when options.throwHttpErrors = false

[ansaru]

Hi,
I use version 0.28.6.
When set options.throwHttpErrors=false in options and then get response after call:
resp = await ky(url, options);
the resp always has status of 200.

Probably, it's a bug.

[sholladay]

I cannot reproduce this.

const response = await ky.get('https://httpbin.org/status/500', { throwHttpErrors : false });
console.log(response.status);  // 500

You will need to submit a full bug report if you believe this is a problem with Ky (and if so, please do so on the issue tracker).

That said, I think we should update this test to explicitly check that a response is returned with the appropriate status.

[ansaru]

Thanks for the answer.

Here is the code that reproduces the error:

const abortController = new AbortController();
    const abort = () => {
      abortController.abort();
    }

    const onDownloadProgressWatcher = (progressObj) => {
      console.log(`propgress: ${progressObj}`);
    }

    async function getError500() {
      const url = 'https://httpbin.org/status/500';
      const options = {
        signal : abortController.signal,
        onDownloadProgress : onDownloadProgressWatcher,
        timeout : 7000,
        method : 'get',
        throwHttpErrors : false,
        headers : { 'Accept': 'application/json' },
      };
      const response = await ky(url, options);

      console.log(response);
    }

[sholladay]

Looks like it's because of the use of onDownloadProgress.

const url = 'https://httpbin.org/status/500';
const options = {
    onDownloadProgress : () => {},
    throwHttpErrors : false
};
const response = await ky.get(url, options);
console.log(response.status);  // 200

Definitely a bug. I've opened #394 to track this.

[sholladay]

See #394 for any further updates.