Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch API calls #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

rseabrook
Copy link

This PR groups API calls into batches of a configurable size. It will collect records from the same stream until it reaches the configured batch size before appending them to the sheet. It partially addresses #1, although this target could still benefit from rate-limiting and/or retry logic.

It works for me running locally. How do you like to test/validate PRs on targets?

Copy link

@GuillemClot GuillemClot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested with tap-hubspot with a large amount of data and the API get no errors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants