Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible API changes #33

Open
hellemo opened this issue Oct 24, 2022 · 2 comments
Open

Possible API changes #33

hellemo opened this issue Oct 24, 2022 · 2 comments

Comments

@hellemo
Copy link
Member

hellemo commented Oct 24, 2022

Things to test/discuss:

  • Use types for safe/unsafe inserts (e.g. UnsafeVarArray) without bounds checks and dispatch for safe/unsafe insertvar
  • Use types for dynamic/static index names? Possibly parametric types (Dynamic/Static, Safe/Unsafe)
  • Alternatively, would it be possible to support @inbounds for safe/unsafe insert/getindex?
@hellemo
Copy link
Member Author

hellemo commented Mar 3, 2023

Alternatively use a parameter for safe/unsafe, to facilitate switch between safe and unsafe. Default to safe to use during development, but be able to easily switch to unsafe for performance in some cases. I guess adding a unsafe option to the normal insertvar! would be non-breaking as long as it defaults to safe.

@trulsf
Copy link
Member

trulsf commented Mar 6, 2023

Little experience with @inbounds, but I think a parameter for safe/unsafe is a good place to start.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants