[Forum] Display who upvoted/downvoted each post. Closes #346 #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twalen
reviewed
Dec 2, 2024
twalen
reviewed
Dec 2, 2024
|
This PR has a bug that causes the latest posts view to not load. I turned the PR to a draft while I investigate why the tests didn't detect this. |
|
Added a test that checks the latest post view with reactions enabled. |
twalen
requested changes
Dec 16, 2024
| models.Prefetch( | ||
| 'reactions', | ||
| to_attr=attr_name, | ||
| queryset=PostReaction.objects.filter(type_of_reaction=rtype).select_related('author')[:max_count], |
There was a problem hiding this comment.
it would be nice to add some ordering here, otherwise we can get random results (especially important during tests): i.e. order_by('-pk')
also you can add Meta class to PostReaction like:
class Meta:
ordering = ['-pk']
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Displays usernames of users who upvoted/downvoted each post in a tooltip.
Only 10 usernames for each post are queried and displayed to improve performance.
I'm using prefetch_related to query necessary reactions for all posts with a single query.
Translation for a single string needs to be added, but afaik I can only do that in Transifex after this is merged?