Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternative time/memory units in config #26

Open
Tracked by #27 ...
tonowak opened this issue Jun 20, 2023 · 3 comments
Open
Tracked by #27 ...

Alternative time/memory units in config #26

tonowak opened this issue Jun 20, 2023 · 3 comments

Comments

@tonowak
Copy link
Collaborator

tonowak commented Jun 20, 2023

Currently it's possible to specify the time limit and memory limit in ms and kb, but one could make a mistake in the three zeros. It's also a bit not readable -- it takes a bit of time to understand that 16000ms is 16s and not e.g. 1.6s.

What I propose:

  • leave the possibility of specifying in ms and kB,
  • add a new way to specify time and memory: memory_limit_mb and time_limit_s, which takes consecutively an integer and a float,
  • implement the same in sio2,
  • assert that when someone specifies e.g. both memory_limit and memory_limit_mb, then their values are equal (e.g. 1000 and 1).
@tonowak
Copy link
Collaborator Author

tonowak commented Jun 20, 2023

What do you think @MasloMaslane ?

@tonowak
Copy link
Collaborator Author

tonowak commented Jun 20, 2023

That would also solve the issue that some people specify the memory limit in powers of 1000, and some in powers of 1024.

(I'm still not sure which one is correct in sio2.)

@tonowak tonowak mentioned this issue Jun 20, 2023
7 tasks
@MasloMaslane
Copy link
Member

I think that's a good idea, but first I'd like to split sinol package management away from sio2 and sioworkers code. I'll try doing that in the coming months

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants