Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove or conditionalize Pascal tests #21

Open
top-sekret opened this issue May 15, 2023 · 1 comment
Open

Remove or conditionalize Pascal tests #21

top-sekret opened this issue May 15, 2023 · 1 comment

Comments

@top-sekret
Copy link
Member

As the usage of Pascal has become a little bit low in recent years, it is no longer customary to have a Pascal compiler, if it ever had been. We have NO_JAVA_TESTS. We could also add NO_PASCAL_TESTS.

@LiquidPL
Copy link
Contributor

IIRC, sandboxed compilation tests should work regardless of the host environment, so these should be fine as is. For system compilers, I think a better way of achieving this would be to detect presence of system fpc and skip tests depending on that, since I see no point in a manual way to disable tests except for when a necessary compiler isn't present on the system.

In general, we should check for:

  • presence of fpc in the host system,
  • presence of Java (javac/java) in the host system,
  • whether sio2jail can be run in the host system (ie. whether the performance counters are exposed to the system),

and disable the respective tests accordingly, and then remove the manual test disable environment variables.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants