Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace 'id' with 'subject_id' #444

Closed
georgiashay opened this issue Feb 4, 2021 · 1 comment
Closed

Replace 'id' with 'subject_id' #444

georgiashay opened this issue Feb 4, 2021 · 1 comment
Labels
bug Something isn't working e4 low effort p2 high priority

Comments

@georgiashay
Copy link
Collaborator

Courseroad is currently taking roads and replacing they subject_id key with an id key. While both technically work, the key should really be subject_id.
@georgiashay georgiashay added bug Something isn't working p2 high priority e4 low effort labels Feb 4, 2021
@miriam-rittenberg
Copy link
Contributor

resolved by PR #445

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working e4 low effort p2 high priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@georgiashay @miriam-rittenberg