Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing a bookmark does not remove its related image preview #883

Open
JamesMenetrey opened this issue Oct 13, 2024 · 1 comment
Open
Labels
bug Something isn't working

Comments

@JamesMenetrey
Copy link

Dear author,

I noticed a behaviour that may be a bug for Linkding.

When the feature Preview Images is enabled, and a bookmark is created and then removed, the related preview image (in the previews directory) is not removed.

As an observation, when the feature Automatically create HTML snapshots is enabled, I acknowledge that creating and removing a bookmark properly deletes the related snapshot files, indicating that the deletion task is executed, despite the preview image file remains.

I could replicate this behaviour on a clean installation of Linkding with a single bookmark, easing to notice that the preview image file is not deleted once the bookmark is removed.

I believe that removing a bookmark should delete the corresponding preview image, as it is no longer used afterwards.

Thanks and cheers!

@sissbruecker
Copy link
Owner

Thanks, that is indeed missing at the moment.

@sissbruecker sissbruecker added the bug Something isn't working label Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants