Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] The StartService task hangs forever when a dependency loop exists between services #5

Open
sisungo opened this issue Aug 28, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@sisungo
Copy link
Owner

sisungo commented Aug 28, 2023

When a dependency loop exists between services, starting it will cause the tasks hang forever.

Minimal Example

The following service is named self.

[service]
type = "oneshot"
dependencies = ["self"]

[exec]
start = "ls"

Expected Behavior

The dependency loop is detected, automatically broken and a warning log is triggered.

Actual Behavior

The task hangs forever.

@sisungo sisungo added the bug Something isn't working label Aug 28, 2023
@sisungo
Copy link
Owner Author

sisungo commented Oct 22, 2023

Priority: Low.

A correct service should not contain dependency loops. When the deadlock is found by someone, the StartService task can be immediately interrupted.

However, we still need to fix the bug in the future. It may cause confusing error information when stopping the service (because StartService is important and cannot be automatically interrupted).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant