From bffdb94b9b1d5450d3d70285eba48e75b8037651 Mon Sep 17 00:00:00 2001 From: Morten Kolstad Date: Tue, 12 Nov 2024 17:09:17 +0100 Subject: [PATCH 1/2] chore: remove extra approval_prompt-param --- apps/frontend/src/components/ConnectWithStravaButton.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/apps/frontend/src/components/ConnectWithStravaButton.tsx b/apps/frontend/src/components/ConnectWithStravaButton.tsx index e2014f55..be55e1d2 100644 --- a/apps/frontend/src/components/ConnectWithStravaButton.tsx +++ b/apps/frontend/src/components/ConnectWithStravaButton.tsx @@ -5,7 +5,7 @@ import { getEnv } from '../utils/environment'; export const getStravaAuthorizeUrl = (params = { forcePrompt: false }) => { const clientId = getEnv().stravaClientId; - return `https://www.strava.com/oauth/authorize?client_id=${clientId}&redirect_uri=${location.origin}/auth/strava&response_type=code&approval_prompt=auto&scope=read,activity:write&approval_prompt=${params.forcePrompt ? 'force' : 'auto'}`; + return `https://www.strava.com/oauth/authorize?client_id=${clientId}&redirect_uri=${location.origin}/auth/strava&response_type=code&scope=read,activity:write&approval_prompt=${params.forcePrompt ? 'force' : 'auto'}`; }; export const ConnectWithStravaButton = () => { From ce24136d7aa4c06e59f907acf02471a96ee44ca5 Mon Sep 17 00:00:00 2001 From: Morten Kolstad Date: Tue, 12 Nov 2024 17:10:17 +0100 Subject: [PATCH 2/2] refactor: remove default forcePrompt false param --- apps/frontend/src/components/ConnectWithStravaButton.tsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/apps/frontend/src/components/ConnectWithStravaButton.tsx b/apps/frontend/src/components/ConnectWithStravaButton.tsx index be55e1d2..8defb942 100644 --- a/apps/frontend/src/components/ConnectWithStravaButton.tsx +++ b/apps/frontend/src/components/ConnectWithStravaButton.tsx @@ -3,14 +3,14 @@ import { chakra, ImageProps, forwardRef, Link } from '@chakra-ui/react'; import logo from '../assets/connect-with-strava.svg'; import { getEnv } from '../utils/environment'; -export const getStravaAuthorizeUrl = (params = { forcePrompt: false }) => { +export const getStravaAuthorizeUrl = (params: { forcePrompt: boolean }) => { const clientId = getEnv().stravaClientId; return `https://www.strava.com/oauth/authorize?client_id=${clientId}&redirect_uri=${location.origin}/auth/strava&response_type=code&scope=read,activity:write&approval_prompt=${params.forcePrompt ? 'force' : 'auto'}`; }; export const ConnectWithStravaButton = () => { return ( - + );