Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix / cleanup rainbow #28

Merged
merged 1 commit into from
Nov 24, 2024
Merged

Fix / cleanup rainbow #28

merged 1 commit into from
Nov 24, 2024

Conversation

SollyBunny
Copy link

Checklist

  • Tested the change ingame
  • Provided screenshots if it is a visual change
  • Tested in combination with possibly related configuration options
  • Written a unit test (especially base/) or added coverage to integration test
  • Considered possible null pointers and out of bounds array indexing
  • Changed no physics that affect existing maps
  • Tested the change with ASan+UBSan or valgrind's memcheck (optional)

SollyBunny
SollyBunny commented Nov 23, 2024
View reviewed changes
Copy link
Author

@SollyBunny SollyBunny left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like buttered bread is edible, this pr is mergable

@SollyBunny SollyBunny force-pushed the tater_rainbow branch 2 times, most recently from 7c04c1a to 7e48da3 Compare November 23, 2024 23:07
@sjrc6 sjrc6 merged commit 3a22a78 into sjrc6:master Nov 24, 2024
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SollyBunny @sjrc6