fix: table produced invalid SVG

skanaar · Apr 12, 2022 · a301fab · a301fab
1 parent 40294d3
commit a301fab
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 0 deletions.
diff --git a/dist/nomnoml.js b/dist/nomnoml.js
@@ -360,6 +360,7 @@
                     cell.width = cellW;
                 }
             }
+            clas.compartments = clas.compartments.filter((e) => !isRowBreak(e));
         },
         transceiver: box,
     };
@@ -2110,6 +2111,9 @@
                 current.attr['text-align'] = a;
             },
             translate: function (dx, dy) {
+                if (Number.isNaN(dx) || Number.isNaN(dy)) {
+                    throw new Error('dx and dy must be real numbers');
+                }
                 current.attr.transform = `translate(${dx}, ${dy})`;
             },
             serialize: function (size, desc, title) {

diff --git a/src/GraphicsSvg.ts b/src/GraphicsSvg.ts
@@ -311,6 +311,9 @@ export function GraphicsSvg(document?: HTMLDocument): ISvgGraphics {
       current.attr['text-align'] = a
     },
     translate: function (dx, dy) {
+      if (Number.isNaN(dx) || Number.isNaN(dy)) {
+        throw new Error('dx and dy must be real numbers')
+      }
       current.attr.transform = `translate(${dx}, ${dy})`
     },
     serialize: function (

diff --git a/src/visuals.ts b/src/visuals.ts
@@ -289,6 +289,7 @@ export var layouters: { [key in Visual]: NodeLayouter } = {
         cell.width = cellW
       }
     }
+    clas.compartments = clas.compartments.filter((e) => !isRowBreak(e))
   },
   transceiver: box,
 }
-Original file line number
+Diff line change
@@ Expand Up / @@ -289,6 +289,7 @@ export var layouters: { [key in Visual]: NodeLayouter } = { @@
             cell.width = cellW
           }
         }
+        clas.compartments = clas.compartments.filter((e) => !isRowBreak(e))
       },
       transceiver: box,
     }
@@ Expand Down @@