Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update skautis/skautis to 3.0.0-alpha.4 #33

Merged
merged 13 commits into from
Sep 20, 2022

Conversation

jan-stanek
Copy link
Member

@jan-stanek jan-stanek commented Apr 10, 2022

Závisí na skaut/Skautis#101, předpokládá vydání verze 3.0.0-alpha.4

Tohle issue by pak mělo být definitivně vyřešené: skaut/Skautis#90

@jan-stanek jan-stanek marked this pull request as draft April 10, 2022 11:49
@jan-stanek jan-stanek marked this pull request as ready for review April 10, 2022 16:49
@jan-stanek jan-stanek changed the title Update skautis/skautis to 3.0.0-alpha.3 Update skautis/skautis to 3.0.0-alpha.4 Apr 10, 2022
@sinacek sinacek requested review from JindrichPilar and fmasa April 10, 2022 17:06
/**
* @param RequestPreEvent|RequestPostEvent|RequestFailEvent $event
*/
public function dispatch($event): void
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tady mě IDE nutí zvednou PHP na 7.2, zvednul jsem i v composeru, skautis/skautis chce stejně >= 7.3

Declaration must be compatible with EventDispatcherInterface->dispatch(event: object|\Psr\EventDispatcher\object). This is only allowed starting with PHP 7.2. 

@jan-stanek jan-stanek mentioned this pull request Sep 16, 2022
2 tasks
@jan-stanek jan-stanek merged commit 248cf53 into skaut:3.x Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant