Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support "charset" and "profile" parameter in accept header #13

Closed
acka47 opened this issue Apr 30, 2019 · 2 comments
Closed

Support "charset" and "profile" parameter in accept header #13

acka47 opened this issue Apr 30, 2019 · 2 comments
Assignees

Comments

@acka47
Copy link
Member

acka47 commented Apr 30, 2019

Currently, the server gives back a 400 Bad Request when charset or profile is set in the accept header. It should give back a 202 instead.

From #11 (comment):

Make sure params beside the mimetype eg. charset, profile etc are taken into account.

put another way (perhaps more importantly), the server shouldn't end up in 400 if all it wants to do is ignore such params in Content-Type. The Content-Type value is valid after all, and it is perfectly normal for a sender to send that (even if they're not required as per LDN spec).

For reference, the LDN Test Suite sends out the equivalent of:
$ curl -iX POST -H'Slug: .jsonld' -H'Content-Type: application/ld+json; profile="http://example.org/profile"; charset=utf-8' https://test.skohub.io/inbox?target=http://test.lobid.org/gnd/118696432 -d '{ "@id": "http://example.net/note#foo", "http://schema.org/citation": { "@id": "http://example.org/article#results" } }'

@acka47
Copy link
Member Author

acka47 commented May 9, 2019

It is now working on the test system, try the curl command in the issue comment or the LDN publisher test. Closing.

@acka47 acka47 closed this as completed May 9, 2019
@acka47
Copy link
Member Author

acka47 commented May 9, 2019

It is now working on the test system, try the curl command in the issue comment or the LDN publisher test. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants