-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Screensaver timeout #525
base: master
Are you sure you want to change the base?
Screensaver timeout #525
Conversation
@@ -61,6 +61,7 @@ export class SettingsComponent { | |||
this.form = this.fb.group({ | |||
flipscreen: [info.flipscreen == 1], | |||
invertscreen: [info.invertscreen == 1], | |||
screenTimeout: [info.screenTimeout, [Validators.required]], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could be wrong, but I don't think it's needed here. There use to be more in settings, but think a lot got moved to the edit component and this may need to be cleaned up?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess you're right. There is no difference without this line (tested with "ng serve").
Should it be removed? Html is trial and error for me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really this whole form (fb) should probably be removed as I don't think its needed in this file anymore. Shouldn't matter if you leave it or remove it, as the whole section should be cleaned up in a separate PR IMO
What about the config-*.cvs files? Do they contain default values for factory images? |
with moving over to LVGL shortly, can this be adapted? |
I'll look into it. We don't have a backlight with OLED, right?
|
Here is a branch with LVGL (untested) |
Take a look at https://docs.lvgl.io/9.2/overview/display.html#inactivity, there's already an inactivity timer built in, which resets automatically on any input, e.g. button press. I think it only needs to be checked in There's no backlight indeed. |
Ah thank you! Is it correct that we need our own timer to call lv_tick_inc? And we would be limited to uint32 with ~49 days of inactivity? |
No, ticks are handled by the framework. Each lv_tick, |
Resolves #515