Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change selftest to allow the bitaxe to boot, even if tests fail #516

Open
skot opened this issue Nov 26, 2024 · 4 comments
Open

change selftest to allow the bitaxe to boot, even if tests fail #516

skot opened this issue Nov 26, 2024 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@skot
Copy link
Owner

skot commented Nov 26, 2024

Currently if one of the selftest tests fail, the Bitaxe will be stuck in selftest mode forever, essentially bricking the Bitaxe for those who don't know how to flash the nvs.

I think that no matter if tests pass or fail we should set nvs selftest=0 and boot normally after the user presses the BOOT button.

Of course it should be very obvious on the OLED and in the logs that tests have failed, so that both users and factories are aware.

@skot skot added the enhancement New feature or request label Nov 26, 2024
@skot skot self-assigned this Nov 26, 2024
@skot
Copy link
Owner Author

skot commented Nov 26, 2024

Also, once we have this functionality then it makes sense to use factory images (selftest=1) on the webflasher @WantClue

@benjamin-wilson
Copy link
Collaborator

selftest=0 should only happen after the user presses the BOOT button, so that it can be power cycled and re-tested.

@skot
Copy link
Owner Author

skot commented Nov 26, 2024

I suppose we could get fancy and require a long press on BOOT to restart (and set selftest=0) if there is a failure?

@skot
Copy link
Owner Author

skot commented Nov 28, 2024

This is addressed in PR #524

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants