Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frequency adjustment function should work for all ASICs #533

Open
skot opened this issue Nov 30, 2024 · 0 comments
Open

frequency adjustment function should work for all ASICs #533

skot opened this issue Nov 30, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@skot
Copy link
Owner

skot commented Nov 30, 2024

It looks like the power_management task has a loop to check for frequency changes, but it doesn't look like do_frequency_transition() is valid for all different ASIC types. This should probably be a function pointer in ASIC_functions to the proper ASIC-specific function to transition the frequency.

if (asic_frequency != last_asic_frequency) {
ESP_LOGI(TAG, "New ASIC frequency requested: %uMHz (current: %uMHz)", asic_frequency, last_asic_frequency);
if (do_frequency_transition((float)asic_frequency)) {
power_management->frequency_value = (float)asic_frequency;
ESP_LOGI(TAG, "Successfully transitioned to new ASIC frequency: %uMHz", asic_frequency);
} else {
ESP_LOGE(TAG, "Failed to transition to new ASIC frequency: %uMHz", asic_frequency);
}
last_asic_frequency = asic_frequency;
}

@skot skot added the bug Something isn't working label Nov 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants