Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: define all GPIO pins in a single place #547

Open
mutatrum opened this issue Dec 3, 2024 · 1 comment · May be fixed by #566
Open

Chore: define all GPIO pins in a single place #547

mutatrum opened this issue Dec 3, 2024 · 1 comment · May be fixed by #566
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@mutatrum
Copy link
Contributor

mutatrum commented Dec 3, 2024

Used pins are all over the codebase. Ideally they should be defined in a single header file.

Quick scan found these, there might be others. This needs to be checked against the schema:

GPIO_NUM_0    BUTTON_BOOT_GPIO
GPIO_NUM_1    BM####_RST
GPIO_NUM_5    LEDZ_R 
GPIO_NUM_6    LEDZ_G 
GPIO_NUM_7    LEDZ_B 
GPIO_NUM_10   BM####_ENABLE
GPIO_NUM_12   BARREL_CONNECTED
GPIO_NUM_35   LEDX_R 
GPIO_NUM_36   LEDX_G 
GPIO_NUM_37   LEDX_B 
GPIO_NUM_47   I2C_MASTER_SDA_IO
GPIO_NUM_48   I2C_MASTER_SCL_IO
@WantClue WantClue added enhancement New feature or request good first issue Good for newcomers labels Dec 7, 2024
@WantClue
Copy link
Collaborator

WantClue commented Dec 7, 2024

That's a good practice we should do.

@mutatrum mutatrum linked a pull request Dec 8, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Put all GPIO defines in gpio_bitaxe.h mutatrum/ESP-Miner
2 participants
@mutatrum @WantClue