Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix failing unit test for large stratum id #546

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

test: fix failing unit test for large stratum id #546

wants to merge 1 commit into from

Conversation

tdb3
Copy link
Contributor

@tdb3 tdb3 commented Dec 3, 2024 •
edited
Loading

PR #243 changes the type of id to int64_t, allowing for ids exceeding a 16-bit integer.
This adjusts an associated unit test to ensure that 16-bit rollover doesn't occur.

After flashing with unit_test_stratum.bin, observed the test passing now:

Running Parse stratum result success with large id...
/home/dev/myrepos/ESP-Miner/components/stratum/test/test_stratum_json.c:128:Parse stratum result success with large id:PASS
Running Parse stratum result success with larger id...
/home/dev/myrepos/ESP-Miner/components/stratum/test/test_stratum_json.c:138:Parse stratum result success with larger id:PASS

@tdb3 tdb3 marked this pull request as ready for review December 3, 2024 16:40
@tdb3
test: fix failing unit test for large stratum id
7573526 
PR skot#243 changes the type of id to int64_t,
allowing for ids exceeding a 16-bit integer.
Adjusts an associated unit test to ensure that
16-bit rollover wouldn't occur.
@tdb3 tdb3 force-pushed the 20241203_adjust_unit_test_failure branch from c2f2093 to 7573526 Compare December 3, 2024 16:53
WantClue
WantClue approved these changes Dec 4, 2024
View reviewed changes
Copy link
Collaborator

@WantClue WantClue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WantClue WantClue WantClue approved these changes

Assignees
No one assigned
Labels
unit_tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tdb3 @WantClue