Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TableReport ENH: tighter layout when nothing selected #1076

Closed
GaelVaroquaux opened this issue Sep 16, 2024 · 2 comments
Closed

TableReport ENH: tighter layout when nothing selected #1076

GaelVaroquaux opened this issue Sep 16, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@GaelVaroquaux
Copy link
Member

As you know, I'm always trying to have tighter layouts (this is really important because it reduces the scrolling in GUIs/IDEs).

Playing with the TableReport (very very cool), I'm thinking that we could move the green hint that appears when nothing is selected to put it where the key bindings appear. We might have to make the sentence a bit shorter, and I suggest "Click cells for info on columns"

The benefit would be less vertical scrolling by default. The drawback would be a "jump" in vertical height when the selected cell appears. I think that it's worth the cost, as we get jumps anyhow with the column vignette appearing below.

@GaelVaroquaux GaelVaroquaux added the enhancement New feature or request label Sep 16, 2024
@jeromedockes
Copy link
Member

discussed IRL at the weekly skrub meeting: there are a couple of other tweaks we want to apply first

  • deleting the stdout ("processing column x/ y") once the report is displayed
  • making sure we don't use a bigger font than the parent
  • seeing if there are places where we can remove a bit of padding without making the report too crowded
  • displaying one fewer rows by default? (not mentioned in meeting, I just thought of it now)

once we have done those, we will consider the trade-off of saving space vs having a jump when we click a cell, which as you mention can be disconcerting as it can cause the thing you just clicked to skip from under your mouse

@jeromedockes
Copy link
Member

IIRC we decided in a real-life meeting that given other changes we have made to the report (some of them outline in my comment above) it is not worth causing the table to jump from under the mouse when we select a cell to save this space.

Please reopen if I misremember!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants